multitheftauto / mtasa-blue

Multi Theft Auto is a game engine that incorporates an extendable network play element into a proprietary commercial single-player game.
https://multitheftauto.com
GNU General Public License v3.0
1.38k stars 424 forks source link

Binds on special_control_left/right don't work #474

Open ArranTuna opened 6 years ago

ArranTuna commented 6 years ago

Describe the bug Binds on special_control_left/right don't work

To Reproduce crun bindKey("special_control_left", "down", function() outputChatBox("left") end)

There is no chatbox output even if you're in a vehicle like a rhino that has special controls

Expected behavior bindKey function to trigger.

Screenshots If applicable, add screenshots to help explain your problem.

MTA Client (please complete the following information): unstated

MTA Server (please complete the following information): n/a

Additional context From https://bugs.mtasa.com/view.php?id=6687

Proxy-99 commented 3 months ago

I can't reproduce the issue It's working noramlly

@Dutchman101 @botder I think you can close this

MegadreamsBE commented 3 months ago

Old bug so might have been fixed in the meantime. Ideally we'd confirm that it was either never a problem or that a commit did indeed fix it. Could argue that just checking that it works now is sufficient but it never hurts to know exactly why it used to be a problem - and appears not to be now in case of an edge case.

Proxy-99 commented 3 months ago

Old bug so might have been fixed in the meantime. Ideally we'd confirm that it was either never a problem or that a commit did indeed fix it. Could argue that just checking that it works now is sufficient but it never hurts to know exactly why it used to be a problem - and appears not to be now in case of an edge case.

I think it's false report not worth to waste time to find out why it was reported since we have so much bugs xd

MegadreamsBE commented 3 months ago

@ArranTuna Could you pitch in on this? I know it's been 5 and half years since you've written this, and I don't know if you had written the underlying bug report this was base on... so I can understand if you don't remember any details.

MegadreamsBE commented 3 months ago

I think it's false report not worth to waste time to find out why it was reported since we have so much bugs xd

I wouldn't see this as a waste of time. Either there's an edge case we're not considering (original bug tracker is gone - so the link with more info is dead), and this remains a valid bug, or we have an issue that we can now close. Either way it's in limbo right now unless we can confirm which of these is true, and why.

Proxy-99 commented 3 months ago

I think it's false report not worth to waste time to find out why it was reported since we have so much bugs xd

I wouldn't see this as a waste of time. Either there's an edge case we're not considering (original bug tracker is gone - so the link with more info is dead), and this remains a valid bug, or we have an issue that we can now close. Either way it's in limbo right now unless we can confirm which of these is true, and why.

I tested in client up both and down works maybe you can test server side bindKey to see if it works too?

ArranTuna commented 3 months ago

@ArranTuna Could you pitch in on this? I know it's been 5 and half years since you've written this, and I don't know if you had written the underlying bug report this was base on... so I can understand if you don't remember any details.

I was the one who manually migrated mantis bug reports to github. I can't remember if I checked this one for validity, since I had to migrate hundreds, I probably didn't stop to check them. Should be closed IMO.

MegadreamsBE commented 3 months ago

@ArranTuna Could you pitch in on this? I know it's been 5 and half years since you've written this, and I don't know if you had written the underlying bug report this was base on... so I can understand if you don't remember any details.

I was the one who manually migrated mantis bug reports to github. I can't remember if I checked this one for validity, since I had to migrate hundreds, I probably didn't stop to check them. Should be closed IMO.

Thanks for confirming. Since it can't be recreated it should be fine to close this one then