search

multitheftauto / mtasa-resources

This project maintains a list of up-to-date resources that come with Multi Theft Auto.
https://multitheftauto.com
MIT License
153 stars 156 forks source link

#359 Hedit delete handlings #360

Closed ricksterhd123 closed 2 years ago

ricksterhd123 commented 3 years ago

This PR should close #359 We will need translations for Arabic, Polish, Russian, Spanish and Turkish. Can I use google translate? I will make this a draft for now, I think I can get Arabic and Spanish but not the rest.

Inder00 commented 3 years ago

I can help with polish!

ricksterhd123 commented 3 years ago

I can help with polish!

Awesome, do you want to submit a PR on my fork and I will merge you? This line here needs to be translated from English to Polish the sentence: "Successfully deleted your handling settings!"

You can edit in github: https://github.com/ricksterhd123/mtasa-resources/blob/hedit-delete-handlings/%5Bgameplay%5D/hedit/client/gui/languages/polish.lua#L39

Dutchman101 commented 3 years ago

For this resource, it will be unmanagable to go through pain and a lot of delays (getting a translation for every feature that adds a new button/text) every time someone contributes a new feature. It can even deter people from opening PR's, having the (potentially indefinite) delay of it being approved in mind. So im in favour of either:

Any thoughts?

mtasa-resources never dealt with resource localization, and now we made this existing resource (hedit) official, which already had its own locale implementation. Using a global localization framework (like Pootle for mtasa-blue) seems overkill in this scenario, and i'm sure no one would work on it (although in the basis of things, it's not ideal that all default resources offer only English.. we can consider setting a target for change in the future) >> EDIT: changed my mind and opened #361

So for now, we can just set specific terms for hedit contributions that require new translations, and i suggest them to be the either one from the list at the beginning of this comment.

ricksterhd123 commented 3 years ago

Russian translation is done via Google Translate. Not sure where I can add this to "pending translations". Ready for review.