search

multitheftauto / mtasa-resources

This project maintains a list of up-to-date resources that come with Multi Theft Auto.
https://multitheftauto.com
MIT License
153 stars 156 forks source link

Admin chat has no message string size limit #373

Closed ricksterhd123 closed 1 year ago

ricksterhd123 commented 2 years ago

Which resource(s) have this problem?

admin Describe the bug

There's no limit to how much text can be put into each message. This can cause lag as a consequence to other admins, potentially crashing their MTA clients depending on how much text you put. Who knows, this could potentialy even crash the server if triggerServerEvent isn't non-blocking.

To Reproduce

Open admin panel, go to admin chat. This won't work on the /a command because the chatbox is limited as it should be! Copy and paste as much text as possible into admin chat and submit the message. Now each message sent after will cause freeze lag to other admins.

Expected behavior

You should not even be able to send that much text.

Screenshots

Version

Ver: 1.5.9-9.21035.0

Additional context

I found this out because I was the troll who did it

iPollo commented 2 years ago

Does this still need to be fixed?

ricksterhd123 commented 2 years ago

Yes, feel free to fix it