search

multitheftauto / mtasa-resources

This project maintains a list of up-to-date resources that come with Multi Theft Auto.
https://multitheftauto.com
MIT License
151 stars 149 forks source link

admin2: Added content for "Users" sub-tab in the "Rights" tab #445

Closed FileEX closed 1 year ago

FileEX commented 1 year ago

This PR add content for "Users" sub tab in the "Rights" tab.

image

FileEX commented 1 year ago

Looks good overall, but two minor issues: 1 - PR fails lint checks 2 - Maybe add a confirmation box (messageBox) when removing a user?

Fixed issues and update texts and added a confirmation window

Feel free to put the rest of your work on this ACL tab in this PR if you want.

I asked a few people on discord and they all answered me unequivocally that I should create a separate PR for each tab. I'd rather be safe and send the tabs as a separate PR than make all the tabs as one PR and then edit and split it all up because someone else won't like it. I will be working on more sub-tabs, but will post them in separate PRs