multitheftauto / mtasa-resources

This project maintains a list of up-to-date resources that come with Multi Theft Auto.
https://multitheftauto.com
MIT License
150 stars 146 forks source link

Improved Msgbox #464

Closed Nico8340 closed 5 months ago

Nico8340 commented 5 months ago

This PR removes the old msgbox resource and creates a new one that provides a much simpler concept and looks better. Available types: info, question, warning, error Available buttons: ok, okcancel, retrycancel, yesno, yesnocancel Képernyőkép 2024-01-28 012351

Nico8340 commented 5 months ago

A set of pictures of the new look in action (default resources) image image image

Fernando-A-Rocha commented 5 months ago

Good job! I would just add more spacing between the title and message, as well as the icon on the left @Nico8340

Nico8340 commented 5 months ago

Good job! I would just add more spacing between the title and message, as well as the icon on the left @Nico8340

Should there be more space vertically or horizontally? @Fernando-A-Rocha

Fernando-A-Rocha commented 5 months ago

Good job! I would just add more spacing between the title and message, as well as the icon on the left @Nico8340

Should there be more space vertically or horizontally? @Fernando-A-Rocha

On the y axis between the 2 text labels, and on the x axis between the image and the texts, imo @Nico8340

Nico8340 commented 5 months ago

On the y axis between the 2 text labels, and on the x axis between the image and the texts, imo @Nico8340

Does they look better now? 😄 @Fernando-A-Rocha image

Fernando-A-Rocha commented 5 months ago

On the y axis between the 2 text labels, and on the x axis between the image and the texts, imo @Nico8340

Does they look better now? 😄 @Fernando-A-Rocha image

I think it looks fine now

Fernando-A-Rocha commented 5 months ago

There is no way to handle when a player clicked a specific button like Ok, Cancel? Seems like all they do is close the window

Nico8340 commented 5 months ago

There is no way to handle when a player clicked a specific button like Ok, Cancel? Seems like all they do is close the window

@Fernando-A-Rocha Of course, it is possible to handle the buttons, the function returns three variables that contain the buttons, and the onClientGUIClick event can be used to handle the responses. They only closes so that the scripts do not have to handle this separately.

Nico8340 commented 5 months ago

By the way, I would like to use this system for the new chat implementation as well, in case of mute, notify the player to end this activity or he will face a bigger sanction.

Nico8340 commented 5 months ago

The changes have been made, but for some reason GitHub says they haven't. (they are now, it was just github's bad ux,.)

Nico8340 commented 5 months ago

I'm closing this pull request because I have a much better idea for the implementation that is completely different from this one.