search

multitheftauto / mtasa-resources

This project maintains a list of up-to-date resources that come with Multi Theft Auto.
https://multitheftauto.com
MIT License
150 stars 146 forks source link

admin: Resource settings button is only displayed if there are settings #490

Closed T-MaxWiese-T closed 1 month ago

T-MaxWiese-T commented 2 months ago

This pull request refers to this feature request (closes #489) about the admin resource where the resource settings button should only be displayed if there are settings. It was difficult to make this change. It felt like I had to study half the code to get an overview.

Fernando-A-Rocha commented 2 months ago

I think the same change should be made to the new admin2 resource because admin "1" will be discontinued afaik

T-MaxWiese-T commented 2 months ago

I think the same change should be made to the new admin2 resource because admin "1" will be discontinued afaik

I assume that you have not tried the latest admin2 resource version. But I have already written the following about the admin2 resource in my issue (#489):

Additional context I have looked at the admin2 resource and there the resource settings are displayed directly, which I think is definitely better.

However, I have considered that instead of an empty grid list if a resource has no settings, it should say “None”, for example, as well as if no description is given, for example. Because a good GUI gives you information. If the user sees an empty grid list, he might think that there is an error during loading. It is also clearer if only what is needed is displayed.

Dutchman101 commented 1 month ago

Thanks!