Refactor of resources meta.xml

multitheftauto / mtasa-resources

This project maintains a list of up-to-date resources that come with Multi Theft Auto.

https://multitheftauto.com

MIT License

150 stars 146 forks source link

Refactor of resources meta.xml #491

Closed Fernando-A-Rocha closed 1 month ago

Fernando-A-Rocha commented 2 months ago

This PR introduces the following changes:

author tag added in resources info that didn't have it (MTA contributors (github.com/multitheftauto/mtasa-resources))
version tag added in resources info that didn't have it (1.0.0)
unnecessary <?xml line removed from all .map and meta.xml files that had it
unused mod="deathmatch" tag removed from all .map files`

Feel free to give your opinion.

To me, the most important change is adding version tags to all resources, so version control standards can be enforced like they are in community.mtasa.com. Example of good practice: https://community.multitheftauto.com/index.php?p=resources&s=details&id=3716

T-MaxWiese-T commented 2 months ago

Does it mean that from now on if a resource is changed for a future release the version number has to be increased?

Fernando-A-Rocha commented 2 months ago

Does it mean that from now on if a resource is changed for a future release the version number has to be increased?

I believe so. This is the responsibility of us, contributors and maintainers of this repository. I don't see why a resource version shouldn't be bumped when it's changed, despite the fact that it's not that useful for now. Maybe in the future there can be a resource update checker.

T-MaxWiese-T commented 2 months ago

Does it mean that from now on if a resource is changed for a future release the version number has to be increased?

I believe so. This is the responsibility of us, contributors and maintainers of this repository. I don't see why a resource version shouldn't be bumped when it's changed, despite the fact that it's not that useful for now. Maybe in the future there can be a resource update checker.

It is already possible to update resources via the server console. The admin panel should actually also have this option. There should be a new lua function for this: bool upgradeResources ( [ bool upgradeAll = true, resource targetResource = nil ] ) And a function that returns the resource names that need to be updated and the latest version: table getUpgradeResources ( [ bool allResources = true, resource targetResource = nil ] )