search

multitheftauto / mtasa-resources

This project maintains a list of up-to-date resources that come with Multi Theft Auto.
https://multitheftauto.com
MIT License
151 stars 151 forks source link

freeroam: fix freezetime flickering #529 #530

Closed ricksterhd123 closed 1 week ago

ricksterhd123 commented 1 month ago

resolves #529

Uses the max value of setMinuteDuration, so in theory 1 minute should just under 25 days.

Fixes the flickering, removes redundant timer and its 3 variables, in mtasa-resources freeroam weather is always static (correct me if I'm wrong), weather should be separate from freeze time.

Note: I can go back and use feature branch on my fork, this was purely accidental, my bad

jlillis commented 1 month ago

Given the original issue is just cosmetic, maybe this could wait until multitheftauto/mtasa-blue#3567 is merged and use setTimeFrozen instead?

ricksterhd123 commented 1 month ago

Given the original issue is just cosmetic, maybe this could wait until multitheftauto/mtasa-blue#3567 is merged and use setTimeFrozen instead?

No rush, please can you ping me once it's been merged and in the next update

*edit: feel free to do this yourself I think the diff mainly removing the old code

jlillis commented 3 weeks ago

@ricksterhd123 https://github.com/multitheftauto/mtasa-blue/pull/3567 is merged into nightly, feel free to update PR when able. Don't forget to update min_mta_version.

jlillis commented 1 week ago

I'm going to make the setMinuteDuration -> setMinuteFrozen change in a follow-up PR.