multiverseweb / Dataverse

This software is currently under development. It can be used to visualise data into various forms of plots ranging from primary to advanced level. It can also be used as a finance tracker.
https://multiverse-dataverse.netlify.app
MIT License
39 stars 109 forks source link

footer update #224

Closed aashutosh585 closed 3 weeks ago

aashutosh585 commented 1 month ago

Hey @multiverseweb ,I have updated Footer of website, Take a look of it if you want some more change ,then let me know

Before

Screenshot 2024-10-22 233257

After

Screenshot 2024-10-23 005007

And don't forgot to add hackcobar-fest gssoc-ext level 2 or level3.

netlify[bot] commented 1 month ago

Deploy Preview for multiverse-dataverse ready!

Name Link
Latest commit f1110a405fd62d5eb72c7167706b9f1bb410f851
Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/672105120a13270009c7a3ce
Deploy Preview https://deploy-preview-224--multiverse-dataverse.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jency1 commented 4 weeks ago

@aashutosh585 Mention the issue number which you have solved.

Also if can add a horizontal line or something at top of all the links, like it is there on top of copyright section.

aashutosh585 commented 4 weeks ago

hey @jency1 , Issue Number is #196 .Take a look of modified footer .if you want something else then tell me. Screenshot 2024-10-25 005215

And don't forgot to add hackcobar-fest gssoc-ext level 2 or level3.

multiverseweb commented 3 weeks ago

@aashutosh585, there are some problems with this PR:

Can you just keep the style of the links as it is in the existing live site and remove the scale-up hover effect? The main change I would like through this PR is moving the copyright section below the links. Good luck!

aashutosh585 commented 3 weeks ago

hey @multiverseweb ,PR no #248 I improve code as your requirement

multiverseweb commented 3 weeks ago

@aashutosh585, there are some problems with this PR:

  • you added css code in <style> tag in html file even when style.css exists. It hinders code consistency and disturbs future contributors.
  • The hover effect on links scales up their size, which moves the position of surrounding links a little. It didn't look good to me.

Can you just keep the style of the links as it is in the existing live site and remove the scale-up hover effect? The main change I would like through this PR is moving the copyright section below the links. Good luck!

@aashutosh585 No commits have been made in this PR after I requested changes. Maybe you forgot to commit? Just check once These are the animations effect I quoted in the earlier message:

https://github.com/user-attachments/assets/e2b0197f-1d0c-4cda-bac1-1121b63001ea

Hovering on one link, moves the contents around it. Can you remove this animation?