Closed aashutosh585 closed 3 weeks ago
Name | Link |
---|---|
Latest commit | f1110a405fd62d5eb72c7167706b9f1bb410f851 |
Latest deploy log | https://app.netlify.com/sites/multiverse-dataverse/deploys/672105120a13270009c7a3ce |
Deploy Preview | https://deploy-preview-224--multiverse-dataverse.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@aashutosh585 Mention the issue number which you have solved.
Also if can add a horizontal line or something at top of all the links, like it is there on top of copyright section.
hey @jency1 , Issue Number is #196 .Take a look of modified footer .if you want something else then tell me.
And don't forgot to add hackcobar-fest gssoc-ext level 2 or level3.
@aashutosh585, there are some problems with this PR:
<style>
tag in html file even when style.css
exists. It hinders code consistency and disturbs future contributors.Can you just keep the style of the links as it is in the existing live site and remove the scale-up hover effect? The main change I would like through this PR is moving the copyright section below the links. Good luck!
hey @multiverseweb ,PR no #248 I improve code as your requirement
@aashutosh585, there are some problems with this PR:
- you added css code in
<style>
tag in html file even whenstyle.css
exists. It hinders code consistency and disturbs future contributors.- The hover effect on links scales up their size, which moves the position of surrounding links a little. It didn't look good to me.
Can you just keep the style of the links as it is in the existing live site and remove the scale-up hover effect? The main change I would like through this PR is moving the copyright section below the links. Good luck!
@aashutosh585 No commits have been made in this PR after I requested changes. Maybe you forgot to commit? Just check once These are the animations effect I quoted in the earlier message:
https://github.com/user-attachments/assets/e2b0197f-1d0c-4cda-bac1-1121b63001ea
Hovering on one link, moves the contents around it. Can you remove this animation?
Hey @multiverseweb ,I have updated Footer of website, Take a look of it if you want some more change ,then let me know
Before
After
And don't forgot to add hackcobar-fest gssoc-ext level 2 or level3.