Closed JahnavikaGopalbvrith closed 2 weeks ago
Thank you for submitting your pull request! π We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! π
Name | Link |
---|---|
Latest commit | 30a83b6488604da054447423b4c6270a79d8cc6c |
Latest deploy log | https://app.netlify.com/sites/multiverse-dataverse/deploys/672d0b51cac9fd00089ba9a9 |
Deploy Preview | https://deploy-preview-282--multiverse-dataverse.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@JahnavikaGopalbvrith There is an error of small white text box below password in both sign up and login page, do fix it.
@jency1 No, it is not an error. It is a password strength meter that displays whether a password is strong, moderate, or weak using a bar. When you enter a password, it will show this information.
@JahnavikaGopalbvrith So change it like that, as anyone who sees can get idea about it. By looking at white box, it seems an error only. So do work on it. Also resolve all conflicts.
@jency1 Is this okay? Any changes Let me know.
@JahnavikaGopalbvrith In login page, Already have an account is not visible. And make the style of both page same in password strength meter.
@JahnavikaGopalbvrith Make all changes and Resolve all conflicts to get the PR merged.
please merge this pr Regards, community manager gssoc-ext
@JahnavikaGopalbvrith the project mentor has already listed some issues in this PR. Kindly fix them too and we'll merge it. Here's the further clarification: Login page:
Sign Up page:
The thickness of password strength meter
is different in both pages, kindly make them equal.
Let me know if you want to discuss this further. Appreciate your reminder @AKSHITHA-CHILUKA
@multiverseweb, I will make the changes and create a pull request.
@multiverseweb, please merge this pull request, as tomorrow is the final day for the gssoc-ext
@multiverseweb, please merge this pull request, as tomorrow is the final day for the gssoc-ext
Resolve conflicts to get the PR merged.
As the resolve conflict button is not enabled I am unable to resolve the conflict I have asked core team about the same issue they told me that the PA or mentor can also resolve the conflict
@JahnavikaGopalbvrith the same issue appears on my device. One way to solve this is by creating a new, cleaner PR. Close this one and create a new PR without any further changes and we will merge it π
Description
266
Email Validation Improvement: Consider adding more specific error messages for invalid email formats. Password Validation Improvement: Implement actual checks to enforce these rules before allowing the login Password Strength Meter Whether the Password is Strong, Moderate or Weak. Clear Input Fields on Successful Login Improvement: Only clear fields if the login is successful, not before. Move the clearing code to after the redirection. Security Features Improvement: Consider implementing additional security features, such as rate limiting on login attempts and two-factor authentication for enhanced security.
Related Issue
Fixes # (issue)
Type of change
Checklist