have changed login to profile and error messeges too

multiverseweb / Dataverse

This software is currently under development. It can be used to visualise data into various forms of plots ranging from primary to advanced level. It can also be used as a finance tracker.

https://multiverse-dataverse.netlify.app

MIT License

39 stars 109 forks source link

have changed login to profile and error messeges too #285

Open vibhamishra09 opened 2 weeks ago

vibhamishra09 commented 2 weeks ago

have changed login to profile button after login and error boxes shows while not following email and password guidelines

have changed login button to profile button after successful login and error boxes arrives when not following email and password guidlines

Fixes #276

Type of change

[x] Bug fix
[x] New feature

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

github-actions[bot] commented 2 weeks ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

netlify[bot] commented 2 weeks ago

Deploy Preview for multiverse-dataverse ready!

Name	Link
Latest commit	99a08a2d0e72dc76893c89237f06dd762d3d8b1b
Latest deploy log	https://app.netlify.com/sites/multiverse-dataverse/deploys/672e5c6d15ec330008d80833
Deploy Preview	https://deploy-preview-285--multiverse-dataverse.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jency1 commented 2 weeks ago

@vibhamishra09 If you can show some video, then it would be better. Because I am not able to see profile image after logging in. Also, resolve all conflicts.

vibhamishra09 commented 2 weeks ago

have made some changes

https://github.com/user-attachments/assets/d0c53b05-eb18-46a3-aca2-8e73aa88562e

jency1 commented 2 weeks ago

@vibhamishra09 Resolve conflicts.

multiverseweb commented 1 week ago

Hey @vibhamishra09, it work great! But here are some changes I would suggest:

fix the path of images and style files in login.html

Current

Expected
Change the content of profile button to the profile image. You can use this image, it is already in the repo: website/web_images/user.png
Change the contents of this page to Currently under development.

Thanks for the wonderful contribution, hope you can make the changes soon. Also, create a new PR when the changes are done as this one has several merge conflicts.