multiverseweb / Dataverse

This software is currently under development. It can be used to visualise data into various forms of plots ranging from primary to advanced level. It can also be used as a finance tracker.
https://multiverse-dataverse.netlify.app
MIT License
39 stars 109 forks source link

Added the ability to toggle between view/hide password in the signup … #315

Closed amin-xiv closed 2 weeks ago

amin-xiv commented 2 weeks ago

Description

Now the user can view/hide their password in both the signup and login page.

Related Issue

Fixes #144

Type of change

Checklist

toggle_password_visiblity

github-actions[bot] commented 2 weeks ago

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better.

netlify[bot] commented 2 weeks ago

Deploy Preview for multiverse-dataverse ready!

Name Link
Latest commit b80d3b7431fa054c07cf3d64cf37e95f7f6617a7
Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/672cf7a7fb6d530008843487
Deploy Preview https://deploy-preview-315--multiverse-dataverse.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jency1 commented 2 weeks ago

@amin-xiv Fix the alignment of toggle button, currently it's on the box.

amin-xiv commented 2 weeks ago

Hi @jency1 , can you please clarify further? Thank you.

multiverseweb commented 2 weeks ago

Hi @amin-xiv here are the two changes required:

Screenshot_2024-11-07-03-33-52-49_40deb401b9ffe8e1df2f1cc5ba480b12

eye-icons-set-password-eye-vision-illustration-sign-collection-suitable-for-design-element-of-user-login-ui-ux-free-vector

amin-xiv commented 2 weeks ago

@multiverseweb Alright thanks for the clarification 👌

amin-xiv commented 2 weeks ago

Hi @multiverseweb , I have updated it, what do you think now? Edit: Whenever I go to deploy preview, and I start inputting a password in the field, I find out that there is an another password visibility toggle button, and I have no Idea from where it comes and it never appears to me locally, and when I go to inspect it in dev tools, it suddenly disappears. Edit: I have just found out that it is a browser extension that is doing this, sorry for that 😅I am going to now restore the original code without the trials of fixing the 'bug'.

github-actions[bot] commented 2 weeks ago

🎉🎉 Thank you for your contribution! Your PR #315 has been merged! 🎉🎉