multiverseweb / Dataverse

This software is currently under development. It can be used to visualise data into various forms of plots ranging from primary to advanced level. It can also be used as a finance tracker.
https://multiverse-dataverse.netlify.app
MIT License
39 stars 109 forks source link

Fix download button. #340

Closed amin-xiv closed 4 days ago

amin-xiv commented 1 week ago

Description

Fixed download button not working in the main page.

Related Issue

Fixes #338

Type of change

Checklist

netlify[bot] commented 1 week ago

Deploy Preview for multiverse-dataverse ready!

Name Link
Latest commit 054cce47a62c0605b500d09d5a10da41c3d36197
Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/67386a9f4f29d90008e8214b
Deploy Preview https://deploy-preview-340--multiverse-dataverse.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 week ago

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better.

multiverseweb commented 1 week ago

Hey @amin-xiv, I think the issue isn't solved in this PR. But I know the reason why its happening. The image with opacity set to 0covers the button. When someone scrolls a little bit, the image shifts downwards and then the button works fine. So you can solve this by increasing the z-index of the button (it should be above the image). Here's the video:

https://github.com/user-attachments/assets/b135aa24-d454-406f-bc7e-a4e15ee3a176

amin-xiv commented 1 week ago

@multiverseweb Ok I'll try my best.

amin-xiv commented 1 week ago

@multiverseweb I have increased the z-index of the button, and the problem you said yesterday about if you scroll up the button won't work and if you scroll down, it will, doesn't happen to me locally nor in deploy preview. What do you think?

multiverseweb commented 4 days ago

@amin-xiv you're right. I'm unable to understand what the issue is too. I'll look into it again and will let you know how it can be solved.

github-actions[bot] commented 4 days ago

🎉🎉 Thank you for your contribution! Your PR #340 has been merged! 🎉🎉