Fixed sidebar and login and signup page issues.

[amin-xiv]

Description

I have found out since the script types of login, signup and the main page has been changed to module, this causes the scripts to automatically use strict mode, which prevents any function in the global scope of the script to be used in the HTML on the onclick attributes (for example), which caused the problems not on the main page, but also in signup and login page.

Related Issue

Fixes #348

Type of change

• [x] Bug fix
• [ ] New feature

Checklist

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented on my code, particularly in hard-to-understand areas
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules

[github-actions[bot]]

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better.

[netlify[bot]]

✅ Deploy Preview for multiverse-dataverse ready!

Name	Link
🔨 Latest commit	2f876bbbdbb1af4e6409296b99cb274ee8b06e1b
🔍 Latest deploy log	https://app.netlify.com/sites/multiverse-dataverse/deploys/673b57027092900008b88ee4
😎 Deploy Preview	https://deploy-preview-349--multiverse-dataverse.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[multiverseweb]

@amin-xiv thanks for resolving the issue. Do you know why type=module attribute is added in the script tag? I didn't add it, maybe some contributor added it.

[github-actions[bot]]

🎉🎉 Thank you for your contribution! Your PR #349 has been merged! 🎉🎉

[amin-xiv]

Hi @multiverseweb, this type="module" has been added by me, when I replaced all of the alert()s in the signup and login page, by custom popups. Since I knew there might be lots of redundant code, its probably more efficient to create a module rather than just repeating the code everywhere, so I created the sharedUtilitites.js file, so that any pages that might have common code between them, import it directly from this file.