Optimize elastic calls when fetching NFT name in transaction operations - Githubissues

multiversx / mx-api-service

Unified REST API facade for providing data related to the MultiversX blockchain

https://api.multiversx.com

GNU General Public License v3.0

30 stars 48 forks source link

Optimize elastic calls when fetching NFT name in transaction operations #1286

Closed tanghel closed 2 months ago

tanghel commented 2 months ago

Reasoning

Too many requests were performed on the ES for fetching NFT names, namely for every transaction that transferred NFTs, a separate ES query was made, thus potentially overloading the ES with a lot of queries on each api call that had the withOperations=true parameter activated

Proposed Changes

perform the fetching of NFT names as a batch for all transactions, not each individual one, thus optimizing the number of round-trips with ES

How to test

/accounts/erd1qqqqqqqqqqqqqpgq6wegs2xkypfpync8mn2sa5cmpqjlvrhwz5nqgepyg8/transactions?function=bulkBuy&withOperations=true&withLogs=true&withScResults=true&size=50 should perform only one round-trip to ES to fetch NFT names