Mempool: handle not-executable transactions related to guardians - Githubissues

multiversx / mx-chain-go

⚡ The official implementation of the MultiversX blockchain protocol, written in golang.

https://multiversx.com

GNU General Public License v3.0

930 stars 202 forks source link

Mempool: handle not-executable transactions related to guardians #6628

Open andreibancioiu opened 3 days ago

andreibancioiu commented 3 days ago

Reasoning behind the pull request

This is an improvement upon https://github.com/multiversx/mx-chain-go/pull/6603.
We should have no / as little as possible not-executable transactions in the bulk of selected transactions.

Proposed changes

https://github.com/multiversx/mx-chain-storage-go/pull/58
Inform selection about not-executable transactions related to guardians, through exporting & using the VerifyGuardian function.

Testing procedure

Standard testing
Send not-executable transactions (related to guardians). Inspect the logs and assert they aren't selected.

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?