Feature Request: /transaction/<hash> should return additional useful fields

multiversx / mx-chain-proxy-go

🐙 MultiversX Proxy: The official implementation of the web proxy for the MultiversX blockchain. An intermediary that abstracts away the complexity of sharding, through a friendly HTTP API.

https://docs.multiversx.com/sdk-and-tools/proxy/

54 stars 18 forks source link

Feature Request: /transaction/<hash> should return additional useful fields #103

Open hiddentao opened 3 years ago

hiddentao commented 3 years ago

The proxy /transaction/<hash> endpoint should additionally return:

The date timestamp
The gasUsed value
The transaction hash (this may seem redundant but is actually useful for when passing the returned object around)
The transaction status field should reflect the actual transaction execution result, i.e passed or failed. In addition to this the error message should be available somewhere (e.g. "not enough gas")

miiu96 commented 3 years ago

These fields that you have mentioned will be added soon in the API transaction structure. Thank you for the feedback. We really appreciate.

miiu96 commented 3 years ago

A part of the information that you need will be merged very soon in the proxy development branch (https://github.com/ElrondNetwork/elrond-proxy-go/pull/104). Hope this will help.

ImPedro29 commented 3 years ago

Hey :), my company is implementing elrond and we did not getting to implement of gasUsed of the transaction, you have a prediction for this implementation?

bogdan-rosianu commented 2 years ago

Hi @hiddentao @ImPedro29 ! As an update for this issue:

the timestamp field has been added
the status resembles the expected value if the endpoint is called with ?withResults=true . Also, smart contract results or receipts with the failing messages are shown as well.

The gasUsed and hash fields have not been added. If we'll add them in the future, I will leave a comment on this issue.

vae520283995 commented 2 years ago

@bogdan-rosianu Hi, no plans to add gasUsed and fee fields yet?