search

multiversx / mx-sdk-dapp

A library that holds the core functional logic of a dapp on the MultiversX
66 stars 63 forks source link

Fixed infinite loop in `parseMultiEsdtTransferData` #1191

Closed razvantomegea closed 2 months ago

razvantomegea commented 2 months ago

Issue

There is an infinite loop in web wallet when signing this transaction:

let transaction: IPlainTransactionObject = { chainID: 'D', receiver: 'erd1qqqqqqqqqqqqqpgqd9z7versxw2pjywsar3mshy8ddhvgjwmzeushy7m7s', sender: 'erd12n774mvuzx5d5fulnx9ykmgykgqtmw8pvc58fzzcyxv96r9sq67sy6m59f', data: 'MultiESDTNFTTransfer@000000000000000005006945e6647033941911d0e8e3b85c876b6ec449db1679@55544b2d353463323862@@091d@55544b4641524d2d653539363331@02@04b4a8335ecc4a780000@55544b4641524d2d653539363331@03@a968163f0a57b4000000@7374616b654661726d', version: 1, value: '0', nonce: account.nonce, gasPrice: GAS_PRICE, gasLimit: 25000000 };

Root cause

In parseMultiEsdtTransferData, the encodedTxCount is 55544b2d353463323862

Contains breaking changes

[x] No

[] Yes

Updated CHANGELOG

[x] Yes

Testing

[x] User testing [] Unit tests