Closed razvantomegea closed 2 months ago
Transactions signing fail on dapp refresh.
Actual Result: Transaction cancelled error appears Expected Result: Transactions are signed and processing
chainID is set to -1 by default. This causes the chainID check to pass as truthy in waitForChainID function and return an incorrect value.
chainID
-1
waitForChainID
Furthermore, the returned chainID will be different than the chainID of the signed transactions, so, those transactions will fail.
Make the chainID '' by default.
''
[x] No
[] Yes
[x] Yes
[x] User testing [] Unit tests
Issue
Transactions signing fail on dapp refresh.
Reproduce
Actual Result: Transaction cancelled error appears Expected Result: Transactions are signed and processing
Root cause
chainID
is set to-1
by default. This causes the chainID check to pass as truthy inwaitForChainID
function and return an incorrect value.Furthermore, the returned chainID will be different than the chainID of the signed transactions, so, those transactions will fail.
Fix
Make the
chainID
''
by default.Additional changes
Contains breaking changes
[x] No
[] Yes
Updated CHANGELOG
[x] Yes
Testing
[x] User testing [] Unit tests