In some cases, consider using non-fixed versions for dependencies

multiversx / mx-sdk-js-core

MultiversX SDK for interacting with the MultiversX blockchain (in general) and Smart Contracts (in particular).

https://multiversx.github.io/mx-sdk-js-core/

Other

58 stars 37 forks source link

In some cases, consider using non-fixed versions for dependencies #290

Closed andreibancioiu closed 3 weeks ago

andreibancioiu commented 1 year ago

E.g. for BigNumber.js. Also, try not to receive (nor return?) BigNumber instances in functions - receive BigNumber.Value interface instead. Try to not break the behavior of instanceof BigNumber.

CiprianDraghici commented 1 year ago

I'd use ~ for some packages. It's a more controlled way to avoid breakings. For minor version upgrades, we should take care of them and when a new version of the sdk-core is released then it will contain all the dependencies upgraded and tested.

For reference: https://stackoverflow.com/a/22345808/1475331

danielailie commented 3 weeks ago

Axios and BigNumber are already as peer dependencies with ^ on sdk-core We also added axios as a peer dependency on network-providers with this pr

Release version: https://www.npmjs.com/package/@multiversx/sdk-network-providers/v/2.5.0