multiversx / mx-sdk-js-wallet-connect-provider

Signing provider for dApps: Wallet Connect.
Other
5 stars 2 forks source link

isConnected - probably more of a question #8

Closed juliancwirko closed 1 year ago

juliancwirko commented 2 years ago

Does it make sense to check the account address in isConnect instead of returning the isInitialized?

isConnected(): Promise<boolean> {
  return new Promise((resolve, _) => resolve(this.isInitialized()));
}

I think this isn't concise for all providers. For example, in the extension, it checks the account, it probably should check the address: https://github.com/ElrondNetwork/elrond-sdk-erdjs-extension-provider/pull/6, but maybe I don't understand how it should work.