multiwavelength / gleam

Galaxy Line Emission & Absorption Modeling
https://github.com/multiwavelength/gleam
BSD 3-Clause "New" or "Revised" License
25 stars 6 forks source link

Negative EW error for absorption line #27

Closed multiwavelength closed 2 years ago

multiwavelength commented 2 years ago

Mariusz Tarnopolski noticed the following issue in GLEAM:

"When an absorption line is fitted, the corresponding amplitude is negative, which results in a negative EW_rest (which can be positive or negative depending on convention), but then - as per line 80 of gaussian_fitting.py - this negative value it carried on to the error, which should always be positive. So I just changed v to abs(v) in that line of the code."

This should be an easy fix as Mariusz suggests.

multiwavelength commented 2 years ago

Fixed in #29.