search

multiwii / baseflight

32 bit fork of the MultiWii RC flight controller firmware
500 stars 356 forks source link

Support for simultaneous GPS and Spektrum satellite and Spektrum satellite binding. #180

Closed jaahaavi closed 10 years ago

jaahaavi commented 10 years ago

I have created couple of improvements:

trollcop commented 10 years ago

is it possible to split this request into separate ones, for example dsmx support in one, then GPS stuff elsewhere.

for example I'm going to add support for speksat on USART3 today, but while I'm there it would be nice to add dsmx. On Nov 3, 2014 6:05 PM, "Jaakko Haavisto" notifications@github.com wrote:

I have created couple of improvements:

  • Possibility to use Spektrum satellite and GPS simultaneous. It's done by using softserial on GPS.
  • 8 channel support for DSMX.
  • Possibility to bind Spektrum satellite with TX without using separate RX for binding.

You can merge this Pull Request by running

git pull https://github.com/jaahaavi/baseflight master

Or view, comment on, or merge it at:

https://github.com/multiwii/baseflight/pull/180 Commit Summary

  • Support for simultaneous GPS and Spektrum satellite
  • Added Spektrum satellite binding to transmitter

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/multiwii/baseflight/pull/180.

jaahaavi commented 10 years ago

Is it ok if I just split this to commits so that one have that Spektrum satellite binding and the other has GPS stuff and that 8 ch support? Or do I have to move that 8 ch stuff to that other request also?

trollcop commented 10 years ago

I think 3 separate commits for binding, 8ch (dsmx), and gps would work.

Assuming the code is good, I would merge spektrum stuff immediately, and gps would be up for review.

On Mon, Nov 3, 2014 at 6:18 PM, Jaakko Haavisto notifications@github.com wrote:

Is it ok if I just split this to commits so that one have that Spektrum satellite binding and the other has GPS stuff and that 8 ch support? Or do I have to move that 8 ch stuff to that other request also?

— Reply to this email directly or view it on GitHub https://github.com/multiwii/baseflight/pull/180#issuecomment-61453711.

trollcop commented 10 years ago

I made some comments on the code, this must be fixed before the patch is even considered.

On Mon, Nov 3, 2014 at 6:19 PM, timecop timecop@gmail.com wrote:

I think 3 separate commits for binding, 8ch (dsmx), and gps would work.

Assuming the code is good, I would merge spektrum stuff immediately, and gps would be up for review.

On Mon, Nov 3, 2014 at 6:18 PM, Jaakko Haavisto notifications@github.com wrote:

Is it ok if I just split this to commits so that one have that Spektrum satellite binding and the other has GPS stuff and that 8 ch support? Or do I have to move that 8 ch stuff to that other request also?

— Reply to this email directly or view it on GitHub https://github.com/multiwii/baseflight/pull/180#issuecomment-61453711.

jaahaavi commented 10 years ago

I will close this request and create those three new ones (with those fixes)

trollcop commented 10 years ago

Sounds good

On Mon, Nov 3, 2014 at 7:31 PM, Jaakko Haavisto notifications@github.com wrote:

I will close this request and create those three new ones (with those fixes)

— Reply to this email directly or view it on GitHub https://github.com/multiwii/baseflight/pull/180#issuecomment-61460263.