search

multiwii / baseflight

32 bit fork of the MultiWii RC flight controller firmware
500 stars 356 forks source link

Jeti EX Bus Rx Support #221

Closed tracernz closed 9 years ago

tracernz commented 9 years ago

I have written some initial code to support Jeti EX Bus receivers (EX Bus is Jeti's high speed serial rx protocol). The protocol spec is available at http://www.jetimodel.com/en/show-file/642/. Initially only RC channel data is supported but eventually (as time permits) I plan to add support for telemetry and Jetibox commands (to enable tuning of gains etc. from the tx). Please provide some feedback :).

ghost commented 9 years ago

Can one of the admins verify this patch?

trollcop commented 9 years ago

Please review the https://github.com/multiwii/baseflight/wiki/CodingStyle wiki. There are too many style violations to list here.

tracernz commented 9 years ago

Yes, I can see a few now :(. I'll fix them up and commit a new revision when I've got time in the next couple of days.

PS. What are your thoughts on the hash defines(there isn't anything on this in the style guide) and the level of commenting?

trollcop commented 9 years ago

Overall it looks OK. Is the half-duplex thing required for later telemetry? There's also the thing that you might be the one and only user of this for a very long time :)

defines are fine, you could right-align the values and comment them but not strictly necessary.

tracernz commented 9 years ago

Is the half-duplex thing required for later telemetry?

Yeah, should have covered that. It uses the tx pin for both directions. If I hadn't included it the rx pin would need to be used for now and then a change to the tx pin later when bidirectional communication is implemented which isn't ideal. One thing I did notice on a quick inspection is that the HoTT telemetry could possibly use it as well instead of requiring a diode to be inserted across the pins.. It's covered on page 597 of the STM32F100x reference manual if you're interested (http://www.st.com/web/en/resource/technical/document/reference_manual/CD00246267.pdf).

There's also the thing that you might be the one and only user of this for a very long time :)

This is true. I'll leave the decision whether to include this in the main distribution or not up to you but I'll continue developing it in my fork regardless :).

fiendie commented 9 years ago

ok to test