multiwii / baseflight

32 bit fork of the MultiWii RC flight controller firmware
499 stars 356 forks source link

Adding cli commands for servo setup #265

Closed schugabe closed 9 years ago

schugabe commented 9 years ago

This commit makes the servo setup via cli commands possible and adds the servo config to the dump command.

ghost commented 9 years ago

Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_299.html

fiendie commented 9 years ago

@schugabe Is this still relevant?

schugabe commented 9 years ago

@fiendie yes it is still relevant. I guess the "coding style violation" is the long if condition. Should this condition be in one line or what is the preferred style here?

fiendie commented 9 years ago

Looks like a line ending fuck-up again :/ Do you have astyle?

ghost commented 9 years ago

Your changes violate the baseflight coding style guidelines: http://dev.baseflight.net:8080/job/Baseflight%20Pull%20Requests/ws/git_diff_304.html

schugabe commented 9 years ago

I installed astyle now. The problem were spaces in empty lines/at the end of lines.

fiendie commented 9 years ago

@trollcop Merge please