search

multiwii / baseflight

32 bit fork of the MultiWii RC flight controller firmware
496 stars 354 forks source link

Baro may return wrong value #269

Open ledvinap opened 9 years ago

ledvinap commented 9 years ago

This bug is present (but probably much harder to trigger) in baseflight: https://github.com/cleanflight/cleanflight/pull/720

trollcop commented 9 years ago

unless you're actually contributing something (like working code), may I politely request you to go fuck yourself, good sir? On Apr 3, 2015 9:42 PM, "Petr Ledvina" notifications@github.com wrote:

This bug is present (but probably much harder to trigger) in baseflight: cleanflight/cleanflight#720 https://github.com/cleanflight/cleanflight/pull/720

— Reply to this email directly or view it on GitHub https://github.com/multiwii/baseflight/issues/269.

digitalentity commented 9 years ago

@trollcop, actually @ledvinap got a point. This bug is likely present in baseflight. Took a while to figure it out here cleanflight/cleanflight#569. In baseflight this line https://github.com/multiwii/baseflight/blob/5fffabbc379dd4cc684fcc2f8b2e940279be7d00/src/sensors.c#L361 probably should be changed to baroDeadline = micros(); to fix this.

trollcop commented 9 years ago

great, go ahead and change it. I'm not clicking any links with joblessflight in them. On Apr 3, 2015 9:56 PM, "Konstantin Sharlaimov" notifications@github.com wrote:

@trollcop https://github.com/trollcop, actually @ledvinap https://github.com/ledvinap got a point. This bug is likely present in baseflight. Took a while to figure it out here cleanflight/cleanflight#569 https://github.com/cleanflight/cleanflight/issues/569. In baseflight this line

https://github.com/multiwii/baseflight/blob/5fffabbc379dd4cc684fcc2f8b2e940279be7d00/src/sensors.c#L361 probably should be changed to baroDeadline = micros(); to fix this.

— Reply to this email directly or view it on GitHub https://github.com/multiwii/baseflight/issues/269#issuecomment-89281114.