search

multiwii / baseflight

32 bit fork of the MultiWii RC flight controller firmware
496 stars 354 forks source link

Update uBlox GPS init parms to change mode to Airborne <1G #299

Closed Nandox7 closed 8 years ago

Nandox7 commented 8 years ago

Picking updates from PatrickE for ublox initialization sequence to enable Airborne <1G mode instead of pedestrian.

ghost commented 8 years ago

Can one of the admins verify this patch?

trollcop commented 8 years ago

ok to test

On Tue, Nov 3, 2015 at 10:21 PM, baseflight-jenkins < notifications@github.com> wrote:

Can one of the admins verify this patch?

— Reply to this email directly or view it on GitHub https://github.com/multiwii/baseflight/pull/299#issuecomment-153350133.

trollcop commented 8 years ago

you removed both .hex files from your commit, don't do that, don't commit/delete them at all.

what does the rest of the patch do? is tehre already code for all of this and it just adds some extra stuff into gps init strings?

On Tue, Nov 3, 2015 at 10:22 PM, timecop timecop@gmail.com wrote:

ok to test

On Tue, Nov 3, 2015 at 10:21 PM, baseflight-jenkins < notifications@github.com> wrote:

Can one of the admins verify this patch?

— Reply to this email directly or view it on GitHub https://github.com/multiwii/baseflight/pull/299#issuecomment-153350133.

Nandox7 commented 8 years ago

damm... didn't noticed that in the commit. We can close this one and I'll submit a new one with those compiled.

As for this patch it changes the working mode for the GPS, so it's only initialization string. The existing initialization string was setting the ublox gps in pedestrian mode, while this one sets it as airborne <1G. What it does in practice is that allows it to behave better in a moving object as the GPS sets its filters for more rapid direction changes. Pedestrian would be better for quads if you'd be doing hovering and PH but I guess in overall the main usage would involve the platform in motion.

trollcop commented 8 years ago

okay, well, anyway, what you wanna do is probly just add those .hex to ignore, i don't want gcc-compiled hex files committed anyway. and fy90q branch is also dead as fuuuck.

so just don't add/delete them at all and all will be g ood.

ya you can close this one and open new one.

On Tue, Nov 3, 2015 at 10:30 PM, Nandox7 notifications@github.com wrote:

damm... didn't noticed that in the commit. We can close this one and I'll submit a new one with those compiled.

As for this patch it changes the working mode for the GPS. The default initialization string was setting the ublox gps in pedestrian mode, while this one sets it as airborne <1G. What it does in practice is that allows it to behave better in a moving object as the GPS sets its filters for more rapid direction changes. Pedestrian would be better for quads if you'd be doing hovering and PH but I guess in overall the main usage would involve the platform in motion.

— Reply to this email directly or view it on GitHub https://github.com/multiwii/baseflight/pull/299#issuecomment-153352517.

Nandox7 commented 8 years ago

ack!

I also need to sync as I noticed my local repo is not picking up latest changes.