syanukov
commented
2 years ago Hi @goncalo-rodrigues,
I've had a look at the task and found an interesting pain point.
On AwsEC2 resource the Ami field has the following tags: hcl:"ami,expr" json:"ami".
,expr is what indeed needed when referencing a block by id
resource "aws_instance" "vm2_aws" {
...
ami = data.aws_ami.vm2_aws.id
...But in the case when a user wants to use a specific AWS ami, the output should be encoded as a string - that is to say, with a quotation mark
resource "aws_instance" "vm_aws" {
...
ami = "ami-074ea14c08effb2d8"
...It means, that we would need a mechanism to conditionally "turn off" the ,expr tag.
Is there already a solution for this or does the hclencoder need to be modified to support the new type of behavior?
goncalo-rodrigues
Multy provides a cloud-agnostic way to specify an image. However, sometimes users want to use a specific AWS ami, or equivalent in other clouds.
This issue adds:
Override field to VM's overrides
Use overrides if specified in translation layer. Similar to how it's done currently for vm sizes - see example for AWS
Add tests for each cloud using their overrides. Copy from this example - https://github.com/multycloud/multy/tree/main/test/_configs/virtual_machine/virtual_machine_size_override but override the image instead of the size. You can see what's currently being generated by running
go test ./test --write_generated- it will create a generated.tf file with the current output of the translation