search

mum-rs / mum

Daemon/cli mumble client
MIT License
31 stars 2 forks source link

Backend split #113

Closed default-username-852 closed 3 years ago

default-username-852 commented 3 years ago

This PR splits the backend implementation into two crates. The benefits of this is that it makes the backend easier to test (since unit tests in binaries are kinda meh), and makes it easier to implement other methods of communicating with an instance of the client (for example over the internet/through GUI). One question left is how do we publish this to crates? We could keep mumd containing everything, but we could also publish a mum crate?

Part of #46.

sornas commented 3 years ago

One question left is how do we publish this to crates? We could keep mumd containing everything, but we could also publish a mum crate?

If one crate is published, everything else also needs to be published. So if mumd depends on mum as it does here, mum has to be published as well. I'm unaware of any workarounds except for reverting to what we had before, which I don't think is a good idea.