search

mum-rs / mum

Daemon/cli mumble client
MIT License
31 stars 2 forks source link

Merge to one crate with bin targets #129

Closed sornas closed 2 years ago

sornas commented 2 years ago

This makes it easier to write something REPL-style which would probably be a better fit for windows. Maybe it makes a GUI/TUI easier too?

We actually get very comparable compilation times. Seems our crate structure didn't really benefit from crates to start with. This is all with lto = "thin" in release (and only once with lots of noise in general).

Version Clean (debug) touch mumd and mumctl only (debug) touch everything (debug) Clean (release) touch mumd and mumctl only (release) touch everything (release)
Split (main) 38.52 s 5.91 s 16.47 s 51.16 s 17.83 s 31.55 s
Monocrate (this PR) 35.86 s 5.54 s 18.27 s 52.45 s 18.55 s 32.02 s
default-username-852 commented 2 years ago

Also, we should update the other mum* crates to signal that we've restructured the project when these changes land.

sornas commented 2 years ago

135