search

mum4k / termdash

Terminal based dashboard.
Apache License 2.0
2.69k stars 133 forks source link

add dim text style as cell.Option #328

Closed icy-comet closed 2 years ago

icy-comet commented 2 years ago

I noticed that termdash/cell maps one-to-one to the styles provided by the tcell API. https://github.com/mum4k/termdash/blob/f13e4222fa62b251e937fa2a00ffab003d814f13/terminal/tcell/cell_options.go#L59-L75

However, the "dim" style from the tcell package is missing from this mapping. If this is not a deliberate decision, adding the style would be a "nice-to-have".

mum4k commented 2 years ago

Hi @icy-comet, thank you for pointing this out. I suspect this is because the "dim" style isn't supported by termbox, which was the initial terminal driver termdash was built upon. We can add the "dim" style and just make the appropriate disclaimers and error messages when termbox is being used.

Is this something you are interested in contributing?