mum4k / termdash

Terminal based dashboard.
Apache License 2.0
2.72k stars 136 forks source link

adding text styles has no effect on Windows #332

Open icy-comet opened 2 years ago

icy-comet commented 2 years ago

I am on the devel branch of termdash and I passed 4 different styles with text.WriteCellOpts to the text.Write call for testing the result. Except, I found only the blink style to be working, as seen in the attached image.

image

Is this an implementation issue at termdash's end or a bug in the upstream lib tcell?

I also tested the same thing with termdash v0.16.0 which was before merging #329, but had the same outcome.

image

Shell: Powershell 7.2.5
Terminal Emulator: Windows Terminal v1.13.11432.0
OS: Windows 11

PS: I know that the styling works on my device because golang-based OhMyPosh, which handles ANSI codes differently, works with all the 4 styles.

icy-comet commented 2 years ago

I just tested the same program inside WSL, and all the styles work fine with the Linux build.

mum4k commented 2 years ago

Thank you for reporting this @icy-comet, considering this works in Linux, chances are the problem is in upstream tcell. We could start by verifying if the tcell support works as expected by running tcell natively without termdash on windows and selecting these options.

@icy-comet please indicate if you are interested in looking into this issue.

icy-comet commented 2 years ago

chances are the problem is in upstream tcell

Seems like it @mum4k.

I just put together a test file according to tcell's getting started guide for 4 text styles — italic, bold, blink and dim.

Here are the results:

Here's the gist I used for testing: https://gist.github.com/icy-comet/76cc7fdbb77f272c5653e533ddebdb63

icy-comet commented 2 years ago

I just opened an issue describing this at tcell's issue tracker: gdamore/tcell#539

mum4k commented 2 years ago

Thank you for following up upstream @icy-comet.