search

mum4k / termdash

Terminal based dashboard.
Apache License 2.0
2.72k stars 136 forks source link

Gauge threshold #342

Closed lovromazgon closed 1 year ago

lovromazgon commented 1 year ago

This PR introduces the option gauge.Threshold which allows you to draw a vertical line on a gauge representing a threshold. If the gauge is drawn with a border the threshold is drawn over the border, otherwise it's only drawn within the gauge itself. The threshold is only drawn if its value is within the gauge (greater than 0 and less than g.total).

I took the liberty to change the demo to draw a threshold on two of the gauges. image

mum4k commented 1 year ago

This looks great, thank you @lovromazgon. I will review and respond in the next few days.

mum4k commented 1 year ago

Close/reopen to trigger CI.

mum4k commented 1 year ago

@lovromazgon, regarding the CLA could you explicitly confirm that you are giving me the permission to also merge this code into the master branch?

We will first merge into devel, I will combine this with a few updates and then release the next Termdash version by merging to master which will require a new CLA check.

lovromazgon commented 1 year ago

I give you explicit permission to treat this code as if it is yours and do with it whatever you want 🙂 It might take me some time to come back and address your comments so feel free to change the code yourself. Otherwise, at the latest, I'll try to do so by the end of the month.

We will first merge into devel

Sorry, I just now saw the note in the contributor's guidelines. My bad!