search

mumax / 3

GPU-accelerated micromagnetic simulator
Other
450 stars 150 forks source link

Feature/shift : copy the border cells when shifting M #221

Closed jsampaio closed 1 year ago

jsampaio commented 5 years ago

this change introduces a new option for the shift. Instead of filling the new cells introduced by shift with the values of ShiftMagL and ShiftMagR, it is now possible to use the current values at the border by setting FudgeShift = true.

It is still needed to set ShiftMagL/R because they're used to determine the shift direction (as is the previous behaviour).

godsic commented 4 years ago

@jsampaio Could you please clean-up this pull request to only contain FudgeShift and provide unit tests?

jsampaio commented 4 years ago

@godsic : it's been a while since I proposed a change to the code, so I have to see how that is done...

A unit test is a script that tests if the function is still working, like e.g. "test/centerwall.mx3" ?

To propose a cleaned-up version, should I make a branch of the current mumax base on the mumax git? Every time I did a new feature on a branch of my own fork, it gets mixed up with all the other changes (like now...)

godsic commented 4 years ago

@jsampaio

Yes, you can mimic that test.

Yes, please make a fork of master, then apply only Feature/shift stuff and make a pull request again.

jsampaio commented 1 year ago

This pull request is replaced by #316 (the same code, but in a clean branch).