search

mumble-voip / grumble

Alternative Mumble server
http://mumble.info/grumble
Other
273 stars 88 forks source link

Ensure we don't close freezelog more than once #44

Closed olabiniV2 closed 4 years ago

olabiniV2 commented 4 years ago

When calling Server.Stop(), it will fail because the freezelog is closed twice. It's a bit hard to find the logic that makes this happen - but a fix that makes it work is to make sure to always set the freezelog to nil after closing it. This commit does that in all places that close the freezelog.

In the files touched, imports are also rearranged by the automatic gofmt rules. I can remove that if it's too noisy.

davidebeatrici commented 4 years ago

In the files touched, imports are also rearranged by the automatic gofmt rules. I can remove that if it's too noisy.

I would split it in a dedicated commit and perhaps also a new pull request.

olabiniV2 commented 4 years ago

Will do!

davidebeatrici commented 4 years ago

You can keep this pull request.