search

mumble-voip / grumble

Alternative Mumble server
http://mumble.info/grumble
Other
275 stars 86 forks source link

use github import paths as they always work and mumble.info does not #7

Closed HorayNarea closed 8 years ago

ghost commented 8 years ago

This could just be fixed by updating mumble.info's HTTPS certificate. In the mean time, you could pass -insecure to go get:

go get -insecure -u mumble.info/grumble/cmd/grumble
HorayNarea commented 8 years ago

I know but why not just use the github paths? The source is hosted here and mumble.info has no informations about grumble other than "it exists"

also: i personally find it more logical that import-paths point directly to where the source "lives" but thats just my opinion :)

HorayNarea commented 8 years ago

another argument to merge this PR: https://github.com/mumble-voip/grumble/issues/4#issuecomment-215698490

mkrautz commented 8 years ago

Fixed SSL for the apex mumble.info. This should work w/o any changes now.

HorayNarea commented 8 years ago

No it doesn't:

go get -v -u mumble.info/grumble/cmd/grumble       
Fetching https://mumble.info/grumble/cmd/grumble?go-get=1
Parsing meta tags from https://mumble.info/grumble/cmd/grumble?go-get=1 (status code 404)
package mumble.info/grumble/cmd/grumble: unrecognized import path "mumble.info/grumble/cmd/grumble" (parse https://mumble.info/grumble/cmd/grumble?go-get=1: no go-import meta tags)
mkrautz commented 8 years ago

Sorry. When I tested it, I "accidently" did go get mumble.info/grumble first ... which, of course, fetches the repo and makes everything work.

I'll fix it.

mkrautz commented 8 years ago

Should be fixed now, can you confirm?

Also, thank you for taking the time to author the patch! But I'd like to keep the current mumble.info URLs.

HorayNarea commented 8 years ago

Yes it's working, thank you!