search

mumble-voip / mumble-docker

The official Mumble Docker image
BSD 3-Clause "New" or "Revised" License
146 stars 34 forks source link

Don't set welcometext if welcometextfile is set #23

Closed restitux closed 2 years ago

restitux commented 2 years ago

Fixes: https://github.com/mumble-voip/mumble-docker/issues/22

azlux commented 2 years ago

You don't need that, check https://github.com/mumble-voip/mumble-docker/blob/master/entrypoint.sh#L49 The function "set_config" have de default parameter and won't apply the config if a no-default value is already set.

Krzmbrzl commented 2 years ago

You do need it, as the default-check only applies if the same variable has been set before. However, in this case these are two separate variables where one overwrites the other nonetheless.