search

mumble-voip / mumble-docker

The official Mumble Docker image
BSD 3-Clause "New" or "Revised" License
146 stars 34 forks source link

feature: Allow loading config values from secrets #29

Closed maweil closed 1 year ago

maweil commented 1 year ago

This PR adds the ability to load configuration values (and the superuser password) from files mounted in /run/secrets/MUMBLE_CONFIG_*files. These are usually created by docker or podman secrets.

I implemented this for my personal use in response to reading issue #27 but decided optimizing it for the default mountpoint of podman secrets, which I tested it with.

Any feedback is appreciated, I plan to add some documentation to the README before marking this PR as Ready for Review.

maweil commented 1 year ago

Hi @Krzmbrzl,

thanks for the review. I have addressed your comments and added an example for running the container with secrets using podman. Is this sufficient or do we need an example for using it with docker as well?

Krzmbrzl commented 1 year ago

added an example for running the container with secrets using podman. Is this sufficient or do we need an example for using it with docker as well?

Given that you linked to the docs, I think it should be fine as it is. If not, we can always add an additional example later. (I'm assuming that both options work kinda similar?)

Krzmbrzl commented 1 year ago

Thanks for implementing this :+1: