search

mumble-voip / mumble-iphoneos

Mumble client for iOS-based devices
https://www.mumble.info
Other
194 stars 79 forks source link

Fixed memory leaks and removed dead code. #51

Closed jinie closed 12 years ago

jinie commented 12 years ago

MUAccessTokenViewController: Fixed memory leak. MUCountryServerListController: Fixed Memory leak. MKNumberBadgeView: Removed dead code. MUMessageBubbleTableViewCell: Removed dead code.

mkrautz commented 12 years ago

I committed the old pull request with the MKNumberBadgeView change reverted (I don't consider it part of mumble-iphoneos, so I'd like not to touch it -- it's just a dep.)

Thanks again! I didn't see this one in time, so the commit text is slightly different.

jinie commented 12 years ago

I closed the old one because I messed it up with various merges etc. I thought GitHub made pull requests as patches, not as actual branches, so I played around with my local repository, and that made a mess of things in the pull request :(

I haven't found anything else that needs fixing, but if you need help (considering i know nothing of audio processing) feel free to throw a few issues at me :)

Anyway, i'll commit the leak fix to MKNumberBadgeView to the original repo.