mumble-voip / mumble-releng

Mumble Release Engineering
Other
17 stars 21 forks source link

buildenv/1.3.x: merge Windows directories in a single one #81

Closed davidebeatrici closed 6 years ago

davidebeatrici commented 6 years ago

There's no need for multiple different directories, as the only thing that changes between a build type and another are the parameters passed to setup.cmd.

mkrautz commented 6 years ago

I obviously prefer the directory approach, such that each target has its own directory, and the uniform way to create a buildenv is to just run setup.cmd.

davidebeatrici commented 6 years ago

The problem is that if we change a dependency build script for a single target, we have to do it in the win32-static directory anyway.

mkrautz commented 6 years ago

I did it this way, mostly to have clear documentation.

However, I can see wanting this, but I don't really see it as a big priority?... I don't see what's too wrong with the old approach?

davidebeatrici commented 6 years ago

80 is currently not suitable to build Mumble for Windows XP, because Qt doesn't support it anymore.

As we discussed, I would like to keep Qt 5.6 for x86 and update to Qt 5.9 for x64, meaning that win32-static and win64-static have to use different build scripts.

We could keep the directories separated and provide the two build scripts in win32-static, but I think that it would cause confusion.