search

mumble-voip / mumble-releng

Mumble Release Engineering
Other
17 stars 21 forks source link

collect_symbols.py use in build relies on outdated path to configuration #82

Open hacst opened 5 years ago

hacst commented 5 years ago

Currently tools/collect_symbols.py assumes the default path for its configuration to be C:\dev\mumble-releng\buildenv\windows\config.json . This used to be a well-known singular location on our internal build slaves where the "current" mumble-releng version and scripts could be found.

However these days this assumption no longer holds. The most recent config can now be found under C:\MumbleBuild\latest-1.3.x\mumble-releng\buildenv\windows on the build slaves. Unfortunately the build scripts we use do not allow us to pass in this parameter. As config.js does not really change the current workaround is to have another checkout in the old location.

This should be properly fixed so the right config from the right releng is used. An alternative might be to completely get rid of this configuration and require configuration from the environment or the build scripts. I'm not sure how relevant the scripts in buildenv/windows are these days. They haven't been touched for 6 years.

The additional checkout in the old location should be removed.