search

mumble-voip / mumble-releng

Mumble Release Engineering
Other
17 stars 21 forks source link

Add check for PowerShell < 4.0 #89

Closed AHOHNMYC closed 5 years ago

AHOHNMYC commented 5 years ago

I had too old PowerShell, and waste almost hour to investigate the root of troubles. Maybe this PR helps other.

davidebeatrici commented 5 years ago

Could you squash the commits, please?

AHOHNMYC commented 5 years ago

Uhm, what I supposed to do? Doesn't GitHub has feature Squash and merge like GitLab?

davidebeatrici commented 5 years ago

Yes, but we usually create a merge commit.

Unfortunately the Squash and merge feature puts the commits directly in the master branch without it.

You can squash the two commits with git rebase -i HEAD~2:

  1. Change pick with squash or s at the beginning of the second commit's line, save and exit the editor.
  2. Delete the second commit's message from the squashed commit's message, save and exit the editor.
  3. Force-push.
AHOHNMYC commented 5 years ago

Done! :smiley_cat:

davidebeatrici commented 5 years ago

Thank you very much for your contribution!