Upgrade smfauth Authenticator to python3

mumble-voip / mumble-scripts

Mumble scripts is a place for gathering various scripts written for the Mumble VoIP application.

https://www.mumble.info

48 stars 31 forks source link

Upgrade smfauth Authenticator to python3 #30

Open Kissaki opened 4 years ago

Kissaki commented 4 years ago

Ran official 2to3 script
Fixed env reference and requirement comment
Fixed string concat + hashing logic

Tested, it works.

Krzmbrzl commented 3 years ago

@Kissaki why has this not been merged yet? Is there any specific reason holding that back?

Kissaki commented 3 years ago

Merge conflict. These changes were based on a different base version. And the intermediate changes I could not understand, seem possibly problematic to me, and were not tested yet.

See PR 27 comments

Sorry for not mentioning that here. I was hoping to resolve this in close time through some clarifications from PR 27 parties, but that was not possible. I did not get around to verifying those changes yet - as it requires a test setup etc.