Closed flxai closed 3 years ago
Also added possibility for custom formatting using string templates.
I see you also changed the indentation character from tab to spaces. Was that intentional?
It’s noteworthy that interpolated strings were introduced into Python version 3.6. So this change effectively makes the minimum version 3.6, not 3.0. Not sure which Python 3 version is currently still supported, or in the oldest Ubuntu/Debian LTS release?
indentation character from tab to spaces. Was that intentional?
No my editor changed this and I didn't notice. Should I revert indentation to tabs?
Not sure which Python 3 version is currently still supported, or in the oldest Ubuntu/Debian LTS release?
Debian LTS currently is stretch for about one more year. Notice that it is also oldstable, so it is encouraged to upgrade systems before that deadline. It uses Python 3.5.3-1. Ubuntu LTS will be Bionic Beaver from next month on. It uses Python 3.6.5-3.
Yes, please revert the intention changes then. They are not the same concern as the other changes in that commit and make the diff less clear.
So not compatible to Debian oldstable
. I think that is okay for this script. The previous script is still available as the previous alternative. So no need to change that.
Yes, please revert the intention changes then.
Fixed in 8351747
Made some changes as pointed out above. Is everything resolved, @Kissaki?
You're welcome. Thanks for the review and merge.
Some small changes to
Non-RPC/mumble-ping.py
to port it to Python 3.