search

mumble-voip / mumble-theme

A simple and modern Mumble theme.
The Unlicense
32 stars 20 forks source link

Added icons for enter-restricted channels #21

Closed Krzmbrzl closed 4 years ago

Krzmbrzl commented 4 years ago

These icons should work for the light and the dark theme equally well.

I'm far from being an artist and thus coloring might have to be adapted in the future.

These icons are needed for https://github.com/mumble-voip/mumble/pull/3929

Krzmbrzl commented 4 years ago

Admittedly these aren't the most beautiful icons ever and someone (perhaps even myself) should tweak them a bit or redesign them. My main concern is that these icons are included in order for my above mentioned PR to get mergeable.

In my opinion restyling these icons can be done, after the feature-backend is mature (and merged)

Krzmbrzl commented 4 years ago

@davidebeatrici could you please merge this PR? Otherwise the linked PR in the Mumble main repo, can't really progress any further

davidebeatrici commented 4 years ago

Where do the icons come from?

The description in the SVG files says "Icon for voice chat program mumble".

Krzmbrzl commented 4 years ago

Uhm I created them. But I didn't add any description of that kind. Let me recheck that I actually added the correct file :eyes:

Krzmbrzl commented 4 years ago

Ah okay now I think I know what's going on. I initially started these SVGs by copying the lock-icon provided in #19 to get the image width and height correct. I assume that RyanThomasTech added this meta-data to his images and I didn't delete it. Thus it is still in there.

But I re-checked and these are absolutely the ones I created myself and not some icons I accidentally copied into this PR. Thus this PR can be merged (from by side) @davidebeatrici :+1:

davidebeatrici commented 4 years ago

I would cleanup the SVG files with https://jakearchibald.github.io/svgomg.

Krzmbrzl commented 4 years ago

That looks like a nice tool. Never heard of it before. But yeah cleaning the SVGs is probably a good idea ^^

Krzmbrzl commented 4 years ago

Wow I am hugely impressed of what this tool was able to do with the images... I uploaded the sanitized versions :point_up:

Btw. I think by merging this PR, you can effectively close #19 as it won't be needed anymore...