Fix various OS X issues with the theme

mumble-voip / mumble-theme

A simple and modern Mumble theme.

The Unlicense

32 stars 20 forks source link

Fix various OS X issues with the theme #6

Closed mkrautz closed 8 years ago

mkrautz commented 8 years ago

One commit fixes the font selection and size for OS X. This includes some refactoring of code to make it easier to override variables in the OS X theme.

The second commit moves OS X output files to the root of the tree, in order to make relative URLs in the stylesheets work across both the default theme variant and the OS X variant.

mkrautz commented 8 years ago

/cc @hacst

hacst commented 8 years ago

LGTM code-wise. Take that with a grain of salt though as I never worked with scss. Bit surprised we didn't notice it not picking up resources earlier. Guess I couldn't test that and missed it when adding the meta information.

Can't judge the merit of the optical changes as I don't have OSX.

mkrautz commented 8 years ago

Landed as b0bce71b4f072cbf1b97286987b240c93a200f6e and 11fa641e85a7366d0555882a2e4c5e8922cfa393