mumble-voip / mumble

Mumble is an open-source, low-latency, high quality voice chat software.
https://www.mumble.info
Other
6.28k stars 1.11k forks source link

murmur.ini enables the deprecated DBus interface by default #1083

Closed crknadle closed 9 years ago

crknadle commented 10 years ago

The default murmur.ini file contains:

# Murmur defaults to not using D-Bus. If you wish to use dbus, which is one of the
# RPC methods available in Murmur, please specify so here.
# 
dbus=session

This seems to enable DBus by default even though it's stated that Murmur defaults to not doing so. In addition the following link under "3rd party Interfaces" states that the DBus interface is deprecated and no longer advised.

http://mumble.sourceforge.net/Contributing

As best I can tell, the "dbus=session" line in the default murmur.ini should probably be commented out. Likewise for Debian packaging, for mumble-server dbus should likely be listed as a "Suggests" rather than "Depends" for the same reason.

Kissaki commented 10 years ago

I agree.

I would not enable Ice by default though, but make it the more prominent (above dbus in the file) option.

crknadle commented 10 years ago

Okay that's good to know; Ice was enabled by default as well in 1.2.4 (but commented out by default in the latest version in git).

For version 1.2.4 I'm thinking of using the following patch (note that mumble.ini.system no longer exists in the latest version in git):

--- a/scripts/murmur.ini.system
+++ b/scripts/murmur.ini.system
@@ -28,21 +28,12 @@
 #dbPrefix=murmur_
 #dbOpts=

-# Murmur defaults to not using D-Bus. If you wish to use dbus, which is one of the
-# RPC methods available in Murmur, please specify so here.
-#
-dbus=system
-
-# Alternate D-Bus service name. Only use if you are running distinct
-# murmurd processes connected to the same D-Bus daemon.
-#dbusservice=net.sourceforge.mumble.murmur
-
 # If you want to use ZeroC Ice to communicate with Murmur, you need
 # to specify the endpoint to use. Since there is no authentication
 # with ICE, you should only use it if you trust all the users who have
 # shell access to your machine.
 # Please see the ICE documentation on how to specify endpoints.
-ice="tcp -h 127.0.0.1 -p 6502"
+# ice="tcp -h 127.0.0.1 -p 6502"

 # Ice primarily uses local sockets. This means anyone who has a
 # user account on your machine can connect to the Ice services.
@@ -59,6 +50,16 @@
 #icesecretread=
 icesecretwrite=

+# Murmur defaults to not using D-Bus. If you wish to use dbus, which is one of the
+# RPC methods available in Murmur, please specify so here.  [The D-Bus interface
+# is now considered deprecated and using it is no longer advised.]
+#
+#dbus=system
+
+# Alternate D-Bus service name. Only use if you are running distinct
+# murmurd processes connected to the same D-Bus daemon.
+#dbusservice=net.sourceforge.mumble.murmur
+
 # How many login attempts do we tolerate from one IP
 # inside a given timeframe before we ban the connection?
 # Note that this is global (shared between all virtual servers), and that
mkrautz commented 10 years ago

Hi @crknadle,

The file murmur.ini.system is generated by the script mkini.sh in scripts. It's called by scripts/release.pl, which is what we use to roll Mumble tarballs.

I think disabling DBus by default for system installs is reasonable at this point.

@Kissaki why would you disable Ice by default, though?

crknadle commented 10 years ago

Hey @mkrautz :-)

Re: murmur.ini.system -- understood, thanks. Re: disabling Ice by default -- the mumble-server-web and mumble-django packages on Debian were removed over a year ago, so AFAIK there isn't a package in Debian that will use the Ice interface.

Kissaki commented 10 years ago

We have multiple murmur.ini files - a murmur.system.ini somewhere that is used for the deb distributions. In the latter, Ice is enabled by default. We decided to check whether we can unify the ini file(s) again, and do so if possible - to decrease ambiguity/confusion. We also agreed on disabling dbus by default, and enabling ice by default (as that was already the case for the deb packages already).

We = @dD0T @mkrautz @Kissaki @Natenom