Minimise to menubar on OS X

[jpike88]

Instead of it running as a dock application, I want the ability for it to run in the menubar (and if possible be opened in a popup window), similar to menutab for gmail or something like that.

It drives me insane when i accidentally close it without realising, this will solve that issue while also cleaning up the application dock, as it shouldn't need a dock slot as it's not something you switch to much after starting it up.

[mkrautz]

The current close-button behavior is indeed very unintuitive for Mac users, and it's something we should do better.

On the other hand, I'd argue that minimizing to the menu bar is also unintuitive for a Mac app. At lest for an app like Mumble.

So, in my opinion, clicking close shouldn't quit the application - only close the main window. But I don't think we should minimize to the menu bar, for consistency with the rest of the system.

If you have any good arguments for doing it, I'd love to hear them.

[mkrautz]

I should also add:

It is very possible, if people are interested in it, to use MumbleKit (https://github.com/mumble-voip/mumblekit) to implement things such as a Mumble client that runs like Menu Tab Pro for GMail without having to deal with the nitty-gritty details for the Mumble protocol itself.

[jpike88]

Sure, a couple of points:

I've found that I can separate my running programs into two classes, primarily based on how often I need to switch to them, interact, open, close etc... you may think of it as either active or passive.

XCode, Photoshop, Safari, FTP/MYSQL clients are a few example of what I'd call 'active' applications. I am likely to switch between them and interact directly with them. If they are open on the dock, it means that they are in 'session' so to speak.

Mumble is what I'd call more of a 'passive' application, because once you open it and connect, you aren't going to interact with it until you either close it or switch channels/servers. Similar menubar only applications which have a menubar component I have include Pivotal Tracker, MenuTab for gmail, f.lux, Skype, Dropbox etc

Some are menubar only, and a couple have presence on the dock with a window tucked away somewhere. However it's a small step for them to consolidate to the menubar really.

[jpike88]

Sweet I will look into it

[mkrautz]

I'll try to look into enabling the "minimize to tray" feature on OS X.

Right now, it's ifdef'd out on OS X for consistency with the platform. However, since people seem to want it, it might make sense to enable it on OS X, and disable it by default, like we do on Windows 8.

Would remove some ifdef soup.

[Streusel]

Just because I was about to make a post regarding this, how is it looking on the mac side, in regards to closing the mumble window such that it doesn't actually exit the mumble app itself?

[jpike88]

Nothing so far...

[eddiewang]

Any updates on this? Specifically the close button. I find it very unintuitive as a Mac user as I expect the app to be minimized to the app bar. Would love to assist if I can :)

[motform]

Bumping this regarding the close button. I'm not familiar with QT so I can't make the change myself, but the fact that mumble is the only application I know with this type of inconsistency really get to you.

[Krzmbrzl]

Did I understand it correctly that you'd like to have a Minimize to tray like behaviour when closing the main window on macOS?

As I don't really have a mac-device available, I'd need at least one of you willing to test my potential changes in that regard :point_up:

Just for reference: I think the relevant code-part is here https://github.com/mumble-voip/mumble/blob/f384cca9de8476601889dfd8db299d514f64c8f7/src/mumble/MainWindow.cpp#L438-L482

[motform]

Yes, exactly! I'd love to help you out and test the change.

[Krzmbrzl]

Okay great :) Have you ever compiled Mumble on Mac @motform ?

Reference for myself: https://stackoverflow.com/questions/3332257/how-do-i-properly-implement-a-minimize-to-tray-function-in-qt