mumble-voip / mumble

Mumble is an open-source, low-latency, high quality voice chat software.
https://www.mumble.info
Other
6.28k stars 1.11k forks source link

[Linux] Links notification showing as HTML in the notifications #2211

Closed Jaizu closed 8 years ago

Jaizu commented 8 years ago

Instead getting "A link" I get <a href="http://a-link.com">A link</a> when someone sends me a link.

This doesn't happen in Windows 7, didn't test in more distros

I'm using Elementary OS Freya, specs: http://i.imgur.com/IjIPqT4.png

Mumble Version: http://i.imgur.com/C6SZI7B.png

Bug screens: Notification: http://i.imgur.com/JNnIN0p.png Link on the channel: http://i.imgur.com/qBG96bR.png

If I need to provide more info just tell me what I'm missing and I will gladly add it.

mkrautz commented 8 years ago

Technically, per the desktop notification spec, this is a violation:

https://people.gnome.org/~mccann/docs/notification-spec/notification-spec-latest.html states that:

The following tags should be supported by the notification server. Though it is optional, it is recommended. Notification servers that do not support these tags should filter them out. ... Bold ... Italic ... Underline ... Hyperlink ... Image

...So, the expected behavior would be to filter the tags away.

I'm preparing a patch to just use plain text instead, since many notification daemons do not seem to be spec compliant in practice.

mkrautz commented 8 years ago

Also, dupe of https://github.com/mumble-voip/mumble/issues/1535.

mkrautz commented 8 years ago

Not a dupe. OP tried to send an HTTP-link.

Jaizu commented 8 years ago

Hi, I don't know if this helps but, what's the point of having link in notifications if we can't click them? I will wait the patch, thanks for the support.

mkrautz commented 8 years ago

There's not much we can do about it. I recommend you file a bug a against elementary OS. We send the messages with HTML in them. According to the spec [1], it should work (or degrade back to plain text automatically). But it doesn't.

ElementaryOS isn't alone in this. See for example https://github.com/mumble-voip/mumble/issues/1535.

[1] https://developer.gnome.org/notification-spec/

mkrautz commented 8 years ago

Actually, reading your bug report, it seems like it isn't regular tags that are affected.

In your screenshots, it seems like this is a dupe of #1535: because, in your screenshots, Mumble is sending -tags with non-HTTP/HTTPS URL schemes, like clientid://, etc.

Reading the spec, I would expect these to be stripped by the notification daemon. But that doesn't seem to happen.

mkrautz commented 8 years ago

One interesting thing to test would be to send a text message with the following content:

<a href="http://www.google.com>A working link?</a>
<a href="mumble://example.com">A broken link?</a>

It is my understanding that the first link would work, while the second link wouldn't.

Jaizu commented 8 years ago

Images with Html and a link here: http://imgur.com/a/FDHJF

They images are large since I'm lazy to cut them, sorry lol

mkrautz commented 8 years ago

Thanks.

I think the HTML from our own log view is confusing the notification daemon...

We'll need to test it some more before taking action...