mumble-voip / mumble

Mumble is an open-source, low-latency, high quality voice chat software.
https://www.mumble.info
Other
6.28k stars 1.11k forks source link

Add a config option to murmur.ini to set superuser password #3226

Open C0rn3j opened 7 years ago

C0rn3j commented 7 years ago

I compiled 1.3.x from git - wanting to set a superuser password requires to annoyingly launch murmur manually with a parameter.

I'd welcome an option to set superuser option via a config line in murmur.ini.

https://wiki.mumble.info/wiki/Murmurguide#Linux_4

If there are other ways to set the superuser password then they are not noted in the wiki.

EDIT: Looks like the superuser password is autogenerated at first start of the server and is in logs. Would still welcome a config option tho.

mkrautz commented 7 years ago

Typically, config options in murmur.ini are the 'defaults' which are then inherited by virtual servers unless a per-vserver option is set.

That makes a murmur.ini option for the SuperUser a little weird: you probably do not want the same SuperUser password on all virtual servers.

Then there's the issue of storing the password in plain text. I'm not going to argue very strongly on that front, because the fact is that we already emit the auto-generated password to the log file in plain text.

One could imagine that a super user password set in murmur.ini would be global, and allow you to log into all virtual servers as SuperUser. But each virtual server would still have its own local password, too. So a global SuperUser password that you can use instead (or alongside) the per-vserver's SuperUser password.

C0rn3j commented 7 years ago

One could imagine that a super user password set in murmur.ini would be global, and allow you to log into all virtual servers as SuperUser. But each virtual server would still have its own local password, too.

That sounds great. I don't use the virtual servers feature so I didn't even think of that as an issue.